feat: jsonforms image upload renderer #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified schema adding "format":"image" to relevant fields
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…-create-image-upload-custom-renderer
dcshzj
reviewed
Jul 10, 2024
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
…e-image-upload-custom-renderer
…h BE, but need to fix CSP(or rewrite dataurl2blob) and suspense, loading&error msg
dcshzj
reviewed
Jul 15, 2024
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
…wise cache user image and display if mutation succeeds)
…e-image-upload-custom-renderer
harishv7
reviewed
Jul 16, 2024
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
...ures/editing-experience/components/form-builder/renderers/controls/JsonFormsImageControl.tsx
Outdated
Show resolved
Hide resolved
apps/studio/src/features/editing-experience/components/form-builder/renderers/controls/utils.ts
Outdated
Show resolved
Hide resolved
karrui
approved these changes
Jul 29, 2024
apps/studio/src/features/editing-experience/components/form-builder/renderers/controls/utils.ts
Outdated
Show resolved
Hide resolved
|
Also realise the image is not previewed on the right side yet. Unsure if it should be in this PR or the next. you decide. just ensure it's not dropped. |
…blob<=>dataurl conversion helper functions) since out of scope for this pr
…image so it shows in the preview
hanpuliu-charles
deleted the
hanpu/isom-1216-create-image-upload-custom-renderer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes ISOM-1216
Made changes to the CSP to allow blob: for images, any security implications from this?
Breaking Changes
Before & After Screenshots
AFTER: